an opinion about this code [crash!]

[R2k]

well ... i was trying and trying and trying and well ..

Code: Select all

int createConsole(char* origin){
    int result=0;
    char* realpath='\0';
    sprintf&#40;realpath,origin&#41;; <------------------------------Crash Here!
    strcat&#40;realpath,"/img/console_bg.png"&#41;; <----------------and here
    printf&#40;"path&#58; %s", realpath&#41;;
    //printf&#40;"Helloo!!!!!!!!"&#41;;
    result=readPNG&#40;realpath&#41;;
    //printf&#40;"result=%i",result&#41;;
    return&#40;result&#41;;
&#125;

compiles and links OK, but when i run it crash in the sprintf but is the same with strcat , strcpy, snprintf ( i'm using newlib ).

i want to know your opinion about this ....

i know a solution for this !!! but ... it's odd ...

[Raphael]

You can't initialize a string like this

char* realpath='\0';

What this does, is just initialize a pointer to a char struct and by setting it to '\0' you make it null pointer. Accessing this will no matter what crash your program.
Use this instead:

char realpath[256];
realpath = '\0';

[hubevolution]

in general ... you need to allocate enough memory for the realpath variable to contain the maximum lenght possible expected for origin variable.

and realpath must be defined like :

Code: Select all

 char realpath[MAX_ORIGIN_LENGTH];

in this case a path can be 255 max as raphael correctly stated :)

[__count]

char realpath[256];
realpath = '\0';

That won't compile.
Either do

*realpath = '\0';

or

realpath[0] = '\0';

[Raphael]

char realpath[256];
realpath = '\0';

That won't compile.
Either do

*realpath = '\0';

or

realpath[0] = '\0';

Jup, right, forgot that [0] in a hurry :) thanks

[R2k]

tnx every1. i solved my prob. hehehehe