Help with an Endless Loop

[elevationsnow]

Im using the graphic headers from lua player and i wrote this function to fill an image
it works if im fill a small area
but if i try to fill a larger area it freezes up on me except it doesnt completley freeze

Code: Select all

/* simple flood fill
 * @xx location in image x
 * @yy location in image y
 * @fcolor color being replaced
 * @ncolor color replacing
 * @image image your working in
 */

Image* flood_fill(int xx, int yy, Color fcolor, Color ncolor, Image* image){
	Color current=getPixelImage(xx,yy,image);
	if&#40;current==fcolor && fcolor!=ncolor && xx>1 && xx<479 && yy>1 && yy<271&#41;
	&#123;
		putPixelImage&#40;ncolor,xx,yy,image&#41;;
		image=flood_fill&#40;xx+1,yy,fcolor,ncolor,image&#41;;
		image=flood_fill&#40;xx-1,yy,fcolor,ncolor,image&#41;;
		image=flood_fill&#40;xx,yy+1,fcolor,ncolor,image&#41;;
		image=flood_fill&#40;xx,yy-1,fcolor,ncolor,image&#41;;
	&#125;
   return image;	
&#125;

[ufoz]

Stack overflow?

[HaQue]

so wheres the actual loop?

[charliex]

most likely stack overflow with the recursion

check out pal heckbert's seed fill instead, its more efficient and non recursive.. its in graphics gems 1

code is in here

ftp://ftp-graphics.stanford.edu/pub/Gra ... Gems/Gems/

[bulb]

Obviously stack overflow. Try rewritting the function, so it uses iterative not recursive method, which in its current state is very inefficient anyway.