SDL HWSURFACE freeing patch

[Archaemic]

While trying to do some fancy stuff using the GU in conjunction with SDL, I noticed that it was impossible to SDL_FreeSurface a hardware surface. After doing some research, I noticed that SDL will only call PSP_FreeHWSurface if surface->hwdata is non-zero. It will also call free on surface->pixels if it is non-zero after calling FreeHWSurface, which obviously won't work if the pixels pointer points to something that isn't in the heap. Therefore, I have created this small patch:

Code: Select all

--- src/video/psp/SDL_pspvideo.c        (revision 2361)
+++ src/video/psp/SDL_pspvideo.c        (working copy)
@@ -515,11 +515,13 @@
 
        surface->pitch = pitch;
        surface->flags |= SDL_HWSURFACE;
+       surface->hwdata = (void*)1; /* Hack to make SDL realize it's a HWSURFACE when freeing */
        return 0;
 }
 static void PSP_FreeHWSurface(_THIS, SDL_Surface *surface)
 {
        vidmem_free(surface->pixels);
+       surface->pixels = NULL;
        return;
 }

[jimparis]

applie in rev 2366, thanks

[danzel]

Thanks Archaemic!!!!